ci: Fix doctests #13831
Merged
ci: Fix doctests #13831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
stinodego
commented
Jan 19, 2024
| @@ -206,17 +206,17 @@ def encode(self, encoding: TransferEncoding) -> Expr: | |||
| ... ) | |||
| >>> colors.with_columns( | |||
| ... pl.col("code").bin.encode("hex").alias("code_encoded_hex"), | |||
| ... ) | |||
| ... ) # doctest: +IGNORE_RESULT | |||
There was a problem hiding this comment.
I couldn't get these special characters right. Will check later - either improve the display of these binary types or we can change the example.
There was a problem hiding this comment.
Ah.. Yeap, had the same.
I think the special characters are fine. It is more information than [binary data], but somehow doctest doesn't understand it?
There was a problem hiding this comment.
In my terminal it looks like below, but when I copy paste it into the example the spacing is off. Not sure what is going on. Have to look a bit more closely.
Indeed this is a nice improvement over just displaying [binary data]!
stinodego
requested review from
c-peters,
alexander-beedie and
MarcoGorelli
as code owners
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.