fix(python): ensure kwargs filter behaviour matches docstring (expect equivalence with eq)
#13864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters and
MarcoGorelli
as code owners
…ct equivalence with `eq`)
alexander-beedie
force-pushed
the
eq-filter-expr
branch
from
acd0390
to
db84d3e
Compare
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Jan 24, 2024
…ct equivalence with `eq`) (pola-rs#13864)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13861.
Frame-level
filterwas behaving inconsistently withexpr.filterand with its own docstring. Should have been usingeqinstead ofeq_missingwhen accumulating filters from kwargs, and the difference could block predicate pushdown.Fixed, extending test coverage to validate generation of a suitable
UserWarningon use ofeqwith "None", and to confirm that the query plan doesn't contain a reference toeq_missing.