fix(rust): Allow casting integer types to Enum #13955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-peters
requested review from
ritchie46,
stinodego,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
ritchie46
reviewed
Jan 24, 2024
| unsafe { &*(self as *const ChunkedArray<T> as *const UInt32Chunked) } | ||
| .clone() | ||
| }, | ||
| DataType::Int8 |
There was a problem hiding this comment.
Shouldn't this only be allowed for Enum?
Do we need to bound check or can underlying categories be OOB? Not sure without looking it up.
There was a problem hiding this comment.
Yes, for other categoricals it does not really make sense. We do the bounds check for enums and globals
The from_global_indices seems to me like a hack, we should always have the rev_map when casting from UInt32 to Categorical and check for it.
ritchie46
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13409