Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr(python): Deprecate dtype_if_empty parameter for Series constructor #13976

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jan 25, 2024

Now that we set empty Series to Null, this parameter is no longer useful. Let's get rid of it.

@github-actions github-actions bot added deprecation Add a deprecation warning to outdated functionality python Related to Python Polars labels Jan 25, 2024
@stinodego stinodego marked this pull request as ready for review January 25, 2024 07:59
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Jan 25, 2024

this parameter is no longer useful. Let's get rid of it.

Agreed!

@stinodego stinodego merged commit e89c8ea into main Jan 25, 2024
13 checks passed
@stinodego stinodego deleted the dtype-if-empty branch January 25, 2024 09:40
@c-peters c-peters added the accepted Ready for implementation label Jan 29, 2024
@j824h
Copy link

j824h commented Jan 29, 2024

I think the deprecation warning can be clarified to explain that dtype parameter can be given to explicitly determine the data types for both empty or non-empty cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation deprecation Add a deprecation warning to outdated functionality python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants