Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): omit implicit 'site' from import-timing test #14009

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix(python): omit implicit 'site' from import-timing test #14009

merged 1 commit into from
Jan 26, 2024

Conversation

alexander-beedie
Copy link
Collaborator

This may help further reduce noise... 🤔
See: https://docs.python.org/3/using/cmdline.html#cmdoption-S

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jan 26, 2024
@alexander-beedie alexander-beedie added internal An internal refactor or improvement test Related to the test suite labels Jan 26, 2024
@stinodego
Copy link
Member

Seems sensible 👍

@stinodego stinodego merged commit 22512e2 into pola-rs:main Jan 26, 2024
11 checks passed
@alexander-beedie alexander-beedie deleted the importtime-test branch January 26, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
fix Bug fix internal An internal refactor or improvement python Related to Python Polars test Related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-beedie @stinodego