Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make Enums an actual datatype #14011

Merged
merged 6 commits into from
Jan 26, 2024
Merged

chore: make Enums an actual datatype #14011

merged 6 commits into from
Jan 26, 2024

Conversation

c-peters
Copy link
Collaborator

This PR makes Enum an actual datatype on the rust side instead of a RevMapping variant:

  • This allows creation of 'unitialized' Enums
  • Makes pattern matching a lot easier

@c-peters c-peters marked this pull request as draft January 26, 2024 10:13
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jan 26, 2024
ritchie46
ritchie46 approved these changes Jan 26, 2024
View reviewed changes
crates/polars-core/src/chunked_array/cast.rs Outdated Show resolved Hide resolved
@c-peters c-peters marked this pull request as ready for review January 26, 2024 13:09
@c-peters c-peters merged commit bfbb921 into pola-rs:main Jan 26, 2024
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 29, 2024
@c-peters c-peters self-assigned this Jan 29, 2024
@c-peters c-peters deleted the enum_datatype branch January 31, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees

@c-peters c-peters

Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-peters @ritchie46