fix(python): multiple read_excel updates
#14039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters and
MarcoGorelli
as code owners
alexander-beedie
force-pushed
the
read-excel-fix
branch
from
9dfa406
to
895d230
Compare
alexander-beedie
changed the title
read_excel when using the new "calamine" engineread_excel updates, fix for datetime → time casts for 00:00:00 before the epoch
alexander-beedie
force-pushed
the
read-excel-fix
branch
4 times, most recently
from
171c5e0
to
709f1e9
Compare
|
FYI: temporarily parking this in Draft as I have now found several issues with our datetime conversions relating to the Update: rebased on top of the temporal fixes (see #14050) - good to go. |
alexander-beedie
changed the title
read_excel updates, fix for datetime → time casts for 00:00:00 before the epochread_excel updates
alexander-beedie
force-pushed
the
read-excel-fix
branch
from
709f1e9
to
6253355
Compare
ritchie46
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes casting from Datetime to Time for specific pre-epoch values where the time was 00:00:00(See: fix(rust,python): some temporal conversion errors for datetimes earlier than
1970-01-01#14050)allwhen determining if a cast should be applied).read_csv_optionsin favour of more genericread_options, which can now be passed through to other engines.eq, noteq_missing).