Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Note that only one name operation is allowed per expression #14075

Merged

Conversation

deanm0000
Copy link
Collaborator

addresses the documentation part of #14010

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Jan 29, 2024
@mcrumiller
Copy link
Contributor

Is this a temporary doc change? I don't see why we shouldn't allow multiple .name operations. Related is #13858. There are currently issues when you perform operations on multiple columns simultaneously and also want to transform the names.

@deanm0000
Copy link
Collaborator Author

I guess it's temporary for as long as only one works per expression. #10782 is also relevant as it's directly asking for an enhancement to make chaining them work. Seems like the documentation should tell people that they aren't chainable.

@ritchie46
Copy link
Member

Thank you @deanm0000. Maybe we can lift that restriction in due time. For now it is good to inform people.

@ritchie46 ritchie46 merged commit ab8a00b into pola-rs:main Jan 30, 2024
12 checks passed
@stinodego stinodego changed the title docs(python): note that only one name operation per expression docs(python): Note that only one name operation is allowed per expression Jan 30, 2024
@deanm0000 deanm0000 deleted the name_docs_specify_only_one_per_expression branch January 30, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants