Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement arithmetic operations for Null columns #14107

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat: Implement arithmetic operations for Null columns #14107

merged 1 commit into from
Jan 30, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Jan 30, 2024 •
edited
Loading

This fixes #14093.

@stinodego stinodego changed the title Feat: Impl arithmetic operations for NullChunked feat: Implement arithmetic operations for Null columns Jan 30, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 30, 2024
stinodego
stinodego approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@reswqa reswqa marked this pull request as ready for review January 30, 2024 16:58
@ritchie46 ritchie46 merged commit badc110 into pola-rs:main Jan 30, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego stinodego approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sub operation not supported for dtype null
3 participants
@reswqa @ritchie46 @stinodego