Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Document that Kleene logic is followed in any_horizontal and all_horizontal #14148

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Feb 1, 2024

This closes #14130.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Feb 1, 2024
@reswqa reswqa marked this pull request as ready for review February 1, 2024 04:25
stinodego
stinodego previously approved these changes Feb 1, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stinodego stinodego dismissed their stale review February 1, 2024 06:26

Actually I spotted some problems with our Kleene docs elsewhere, sec...

Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to include an additional description of Kleene logic for any/all (so people will not have to read wikipedia), like I did elsewhere, but I noticed I had incorrectly described Kleene logic for all (it's different from any). Updated now and good to merge.

@stinodego stinodego merged commit 92b2565 into pola-rs:main Feb 1, 2024
11 checks passed
@reswqa
Copy link
Collaborator Author

reswqa commented Feb 1, 2024

I wanted to include an additional description of Kleene logic for any/all (so people will not have to read wikipedia)

Great, Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that Kleene logic is followed in any_horizontal and all_horizontal, expand examples
2 participants