feat: Polish decimal arithmetic #14172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: * performance, and * u128 cannot convert to ArrowDataType
flisky
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
github-actions
bot
added
enhancement
ritchie46
approved these changes
Feb 3, 2024
| |lhs, rhs_val| decimal::div_scalar(lhs, rhs_val, &rhs.dtype().to_arrow(true)), | ||
| |lhs_val, rhs| decimal::div_scalar_swapped(lhs_val, &self.dtype().to_arrow(true), rhs), | ||
| ) | ||
| // Follow postgres and MySQL adding a fixed scale increment of 4 |
There was a problem hiding this comment.
Interesting. And then they accept that after a few multiplication it simply doesn't fit?
There was a problem hiding this comment.
Actually, the comment is from https://github.com/apache/arrow-rs/blob/0dda129be715a95981f0151c8378f0b0b37a4ae9/arrow-arith/src/numeric.rs#L791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup #9123