Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): Implement strict/nonstrict conversion for primitive AnyValues #14186

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Feb 1, 2024

Ref #11156

Changes

Implement strict construction for primitives:

  • Allow any mix of integers as long as they can be cast without overflow.
  • Allow constructing f64 from a mix of f32/f64
  • Allow constructing f32 only from f32

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature rust Related to Rust Polars labels Feb 1, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7698c31) 77.95% compared to head (d8c6051) 77.96%.
Report is 1 commits behind head on main.

Files Patch % Lines
crates/polars-core/src/series/any_value.rs 93.82% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14186   +/-   ##
=======================================
  Coverage   77.95%   77.96%           
=======================================
  Files        1326     1326           
  Lines      173076   173120   +44     
  Branches     2448     2448           
=======================================
+ Hits       134917   134966   +49     
+ Misses      37715    37710    -5     
  Partials      444      444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit e7dae2a into main Mar 2, 2024
25 checks passed
@ritchie46 ritchie46 deleted the av-num-primitive branch March 2, 2024 11:38
@c-peters c-peters added the accepted Ready for implementation label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants