fix(python): Don't ignore timezones in list of dicts constructor

[deanm0000]

fixes:

closes #12151
closes #12638
closes #7620

I initially was hesitant to touch this issue in python thinking it was in rust but I see that sequence_to_pyseries is handling timezones for a dict of lists so the issue was never in rust, it was just lack of implementation. Unfortunately unless we want to turn a list of dicts into a dict of lists in python, it fixes this through a post PyDataFrame cast

[MarcoGorelli]

since #16828 has been merged there's some conflicts - do you have time to fix them up, and update the logic accordingly? I think it should be much simpler now, just use convert_time_zone

sorry this took a while to get round to

[deanm0000]

It'll probably be awhile before I'll be able to make the time to get into it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.51%. Comparing base (383c48a) to head (4049887).
Report is 133 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14211      +/-   ##
==========================================
+ Coverage   80.47%   80.51%   +0.03%     
==========================================
  Files        1483     1504      +21     
  Lines      195118   197156    +2038     
  Branches     2778     2806      +28     
==========================================
+ Hits       157019   158733    +1714     
- Misses      37588    37902     +314     
- Partials      511      521      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MarcoGorelli]

thanks @deanm0000 , sorry it a while to get to - I think the logic can now be considerably simplified. I've added some commits, fancy taking a look to see if they make sense to you?

[MarcoGorelli]

@alexander-beedie fancy taking a look at this one?

[alexander-beedie]

@alexander-beedie fancy taking a look at this one?

Looking ✌️

[alexander-beedie]

@deanm0000: I want to push a few small updates to the branch to streamline this a bit further, but despite "Maintainers are allowed to edit this pull request" being checked, I can't seem to push to the branch; could you invite/enable me directly? :)

remote: Permission to deanm0000/polars.git denied to alexander-beedie. 
unable to access 'https://github.com/deanm0000/polars.git/': 

[deanm0000]

@alexander-beedie I don't know how. I tried googling a bit and it wasn't obvious.

@MarcoGorelli you put commits in. Any tips here?

[alexander-beedie]

@alexander-beedie I don't know how. I tried googling a bit and it wasn't obvious.

Think this should do it? 🤔

[MarcoGorelli]

hey @alexander-beedie - I don't think extra permissions are required, all you should need to do is:

git remote add deanm0000 git@github.com:deanm0000/polars.git
git fetch deanm0000
git checkout datetime_timezone_from_dicts
# make your changes
git commit -a -m 'make awesome changes :sunglasses:'
git push

[deanm0000]

@alexander-beedie I added you as a collaborator but it didn't ask for permissions so not sure if it'll actually do anything. Hopefully (probably) it'll be moot and @MarcoGorelli's suggestion will work.

[alexander-beedie]

@alexander-beedie I added you as a collaborator but it didn't ask for permissions so not sure if it'll actually do anything.

This did the trick - just pushed successfully. Odd that it was required, but such are the vagaries of git(hub)! Will approve/merge once CI is green ✅

[alexander-beedie]

> git commit -a -m 'make awesome changes :sunglasses:'

My favourite kind of changes! 😎