New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): remove unused method DataFrame._from_dicts #14212

Merged

alexander-beedie merged 2 commits into pola-rs:main from lukemanley:remove-from-dicts

Feb 2, 2024

Contributor

lukemanley commented Feb 2, 2024

No description provided.


          remove unused method DataFrame._from_dicts

bead51f

lukemanley requested review from ritchie46, stinodego, c-peters, alexander-beedie and MarcoGorelli as code owners

February 2, 2024 12:42

github-actions bot added internal python labels


          remove import

9a2d80d

Collaborator

alexander-beedie commented Feb 2, 2024 •

edited

Loading

Well spotted; internally we'll go via _sequence_of_dict_to_pydf now (after getting there via DataFrame init) 👍

alexander-beedie approved these changes

View reviewed changes

alexander-beedie merged commit 53f91f5 into pola-rs:main

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

alexander-beedie alexander-beedie approved these changes

ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

stinodego Awaiting requested review from stinodego

c-peters Awaiting requested review from c-peters c-peters is a code owner

MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Labels

internal python