feat(python): Change Series.to_numpy to return f64 for Int32/UInt32 Series with nulls instead of f32
#14240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking python
|
This can be merged. It doesn't fit all possible values and I don't expect this to break any code. |
stinodego
changed the title
Series.to_numpy to return f64 for Int32/UInt32 Series instead of f32Series.to_numpy to return f64 for Int32/UInt32 Series instead of f32
stinodego
removed
the
breaking python
stinodego
changed the title
Series.to_numpy to return f64 for Int32/UInt32 Series instead of f32Series.to_numpy to return f64 for Int32/UInt32 Series with nulls instead of f32
ritchie46
reviewed
Feb 3, 2024
stinodego
force-pushed
the
fix-np-i32-float
branch
2 times, most recently
from
c1463d7
to
6d57b33
Compare
stinodego
requested review from
c-peters,
alexander-beedie and
MarcoGorelli
as code owners
…nt32` Series instead of `f32`
stinodego
force-pushed
the
fix-np-i32-float
branch
from
e2db178
to
85b39a7
Compare
stinodego
force-pushed
the
fix-np-i32-float
branch
from
85b39a7
to
772bfdd
Compare
ritchie46
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this can just be merged, but returning
f32here was not correct since it may lose precision.