Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Remove *args in Series.to_numpy #14248

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

stinodego
Copy link
Member

I wanted to deprecate this, but turns out it doesn't even work currently because we also pass the keyword arguments directly:

import polars as pl

pl.Series([1, 2]).to_numpy(True)
# TypeError: to_numpy() got multiple values for keyword argument 'zero_copy_only'

So I'm removing this.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Feb 4, 2024
@stinodego stinodego merged commit 7749371 into main Feb 4, 2024
12 checks passed
@stinodego stinodego deleted the np-depr-args branch February 4, 2024 01:51
@c-peters c-peters added the accepted Ready for implementation label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants