Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implements prefix/suffix_fields #14251

Merged
merged 3 commits into from
Feb 4, 2024
Merged

feat: Implements prefix/suffix_fields #14251

merged 3 commits into from
Feb 4, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Feb 4, 2024 •
edited
Loading

This closes #14173.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Feb 4, 2024
@reswqa reswqa marked this pull request as ready for review February 4, 2024 07:04
ritchie46
ritchie46 approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ritchie46 ritchie46 merged commit 268501a into pola-rs:main Feb 4, 2024
23 checks passed
@reswqa reswqa deleted the prefix_fields branch February 4, 2024 09:58
@cmdlineluser
Copy link
Contributor

I think this also closes: #10919 and #5169

Thanks!

This was referenced Feb 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support name prefix, suffix, ... on struct field names
3 participants
@reswqa @cmdlineluser @ritchie46