-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Preserve name when casting to Enum #14320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one comment about the test!
@@ -579,25 +579,29 @@ def test_strict_cast_string_and_binary( | |||
|
|||
|
|||
@pytest.mark.parametrize( | |||
"dtype_out", | |||
("dtype_in", "dtype_out"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you just make a separate test test_cast_enum_name_retention
? That should make things a bit cleaner.
dfe01b2
to
08d11a4
Compare
08d11a4
to
e805075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Resolves #14318.