fix(python): fix ufunc for unlimited column args #14328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanm0000
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie and
MarcoGorelli
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10512
#14216
Since the ufunc only passes to
__ufunc_array__the number of args that are actually required, we can't reduce (see the linked issue for more details). Users must reduce themselves. As such, I took out thepyreduceand instead we can create structs automatically. Before this change, the usage of pyreduce just allowed for exactly 2 inputs but no more than 2 so it wasn't really reducing in the true sense of the word.When this gets merged I'll revise #13392 this to incorporate the new capabilities.