Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Internal rename of _or to or_ in PyO3 (same for _xor/_and) #14393

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

stinodego
Copy link
Member

Clashes with built-ins should be resolved by appending an underscore, not prepending one (signalling a private method).

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Feb 9, 2024
@stinodego stinodego marked this pull request as ready for review February 9, 2024 18:19
@stinodego stinodego merged commit 4d79e97 into main Feb 9, 2024
16 checks passed
@stinodego stinodego deleted the orxorand branch February 9, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant