Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Raise if invalid strategy is passed to map_elements #14397

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

closes #14396

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Feb 9, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 9, 2024 20:26
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I think we should instead address this by implementing the "cabbage" strategy.

(j/k thanks for the fix!)

@stinodego stinodego changed the title fix(python): raise if invalid strategy is passed to map_elements fix(python): Raise if invalid strategy is passed to map_elements Feb 9, 2024
@stinodego stinodego merged commit de02091 into pola-rs:main Feb 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map_elements(..., strategy='cabbage') doesn't raise
2 participants