feat: Raise if pivot would introduce duplicate column names
#14431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
MarcoGorelli
commented
Feb 12, 2024
Comment on lines
+431
to
+433
| // we drop early as the brchk thinks the &str borrows are used when calling the drop | ||
| // of both `columns` and `names` | ||
| drop(names); |
There was a problem hiding this comment.
taken from
polars/crates/polars-core/src/frame/mod.rs
Lines 264 to 266 in 32df09e
I wouldn't have thought of this
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie and
orlp
as code owners
stinodego
requested changes
Feb 12, 2024
|
yup, thanks for your review! |
stinodego
changed the title
pivot would introduce duplicate column names
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
ritchie46
reviewed
Feb 12, 2024
| /// # Panic | ||
| /// It is the callers responsibility to uphold the contract of all `Series` | ||
| /// having an equal length, if not this may panic down the line. | ||
| pub fn new_no_length_checks(columns: Vec<Series>) -> PolarsResult<DataFrame> { |
There was a problem hiding this comment.
This should be tagged unsafe as it doesn't check the invariant of DataFrame.
There was a problem hiding this comment.
I can make a quick patch! For reference, the new_no_checks method has the following signature:
pub const fn new_no_checks(columns: Vec<Series>) -> DataFrame
Is this correct or should that also be tagged unsafe?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14305