Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Refactor arg_min/max test case #14439

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

petrosbar
Copy link
Contributor

arg_min/arg_max test case has become a little long and bloated. Broke it down a bit, removed some duplicate test instances, and parametrized it.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Feb 12, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks!

@stinodego stinodego changed the title chore(python): Refactor arg_min/max test case test(python): Refactor arg_min/max test case Feb 12, 2024
@stinodego stinodego changed the title test(python): Refactor arg_min/max test case test(python): Refactor arg_min/max test case Feb 12, 2024
@stinodego stinodego merged commit 5c87741 into pola-rs:main Feb 12, 2024
13 checks passed
@petrosbar petrosbar deleted the refactor-test-argminmax branch February 12, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants