perf: If there are many small chunks in write_parquet(), convert to a single chunk (#14484) #14487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamarst
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
github-actions
bot
added
performance
itamarst
changed the title
ritchie46
reviewed
Feb 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14487 +/- ##
=======================================
Coverage ? 80.35%
=======================================
Files ? 1352
Lines ? 174669
Branches ? 2436
=======================================
Hits ? 140353
Misses ? 33844
Partials ? 472 ☔ View full report in Codecov by Sentry. |
itamarst
commented
Feb 21, 2024
| @@ -133,7 +133,11 @@ pub fn split_series(s: &Series, n: usize) -> PolarsResult<Vec<Series>> { | |||
| split_array!(s, n, i64) | |||
| } | |||
|
|
|||
| pub fn split_df_as_ref(df: &DataFrame, n: usize) -> PolarsResult<Vec<DataFrame>> { | |||
| pub fn split_df_as_ref( | |||
There was a problem hiding this comment.
This is technically a public API, though nothing uses it at least in Polars, just split_df(), so if backwards compat is an issue then this could be a new function and split_df_as_ref could be a wrapper. (Shame Rust has no default keyword args, makes this sort of change easier to be backwards compat.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14484
Before:
After: