Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): Add writable flag to DataFrame.to_numpy #14520

Merged
merged 6 commits into from
Feb 16, 2024
Merged

feat(python): Add writable flag to DataFrame.to_numpy #14520

merged 6 commits into from
Feb 16, 2024

Conversation

dannyfriar
Copy link
Contributor

@dannyfriar dannyfriar commented Feb 15, 2024 •
edited by stinodego
Loading

Closes #14519
Ref #14334

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Feb 15, 2024
@dannyfriar dannyfriar mentioned this pull request Feb 15, 2024
Closed
stinodego
stinodego requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a writable (note: writable, not writeable) flag is a good idea. Please see Series.to_numpy on how to implement it.

@stinodego stinodego changed the title feat(python): writeable flag to to_numpy feat(python): Add writable flag to DataFrame.to_numpy Feb 15, 2024
@ritchie46
Copy link
Member

This isn't ok. We cannot set viewed memory as writeable. That means numpy will write to polars immutable data?!

@stinodego
Copy link
Member

stinodego commented Feb 15, 2024 •
edited
Loading

This isn't ok. We cannot set viewed memory as writeable. That means numpy will write to polars immutable data?!

It should be implemented like in Series.to_numpy: after creating the numpy array, if it isn't writable and writable=True, make a copy.

@ritchie46
Copy link
Member

Yeap, that would be fine.

@dannyfriar
Copy link
Contributor Author

Ok makes sense, I will make the change

stinodego
stinodego approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stinodego stinodego merged commit e8d807b into pola-rs:main Feb 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add writable flag to DataFrame.to_numpy
3 participants
@dannyfriar @ritchie46 @stinodego