Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(python): Add test on selecting Enum columns #14628

Merged
merged 3 commits into from
Feb 21, 2024
Merged

test(python): Add test on selecting Enum columns #14628

merged 3 commits into from
Feb 21, 2024

Conversation

c-peters
Copy link
Collaborator

fix #13269
close #13891

We already support it with the current code base, this PR supersedes the previous one and adds the test to the code base.
Thanks @collinprince!

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Feb 21, 2024
@c-peters c-peters mentioned this pull request Feb 21, 2024
Closed
stinodego
stinodego approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nitpick about the tests, you can decide if you want to use the suggestion.

py-polars/tests/unit/datatypes/test_enum.py Outdated Show resolved Hide resolved
@stinodego stinodego changed the title chore: add test on selecting Enum columns test(python): Add test on selecting Enum columns Feb 21, 2024
@stinodego stinodego removed the rust Related to Rust Polars label Feb 21, 2024
@c-peters c-peters merged commit 4f5436a into pola-rs:main Feb 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow pl.col(pl.Enum) for selecting all Enum columns
2 participants
@c-peters @stinodego