refactor(rust): Simplify compressed_chunk_size calculation and leave comments to explain for rle encode #14634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave comments to explain
nameexhaustion
changed the title
nameexhaustion
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14634 +/- ##
=======================================
Coverage 80.75% 80.76%
=======================================
Files 1326 1326
Lines 173086 173087 +1
Branches 2453 2453
=======================================
+ Hits 139773 139786 +13
+ Misses 32838 32827 -11
+ Partials 475 474 -1 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Feb 22, 2024
nameexhaustion
changed the title
stinodego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the change from #13883.
might also give a tiny performance bump