Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Use datetime_to_int util for AnyValue conversion #14743

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Feb 28, 2024

Changes

  • Use the existing datetime_to_int util instead of _datetime_for_any_value/_datetime_for_any_value_windows.

These Python utils were introduced in #8209, but there already existed a util to do that conversion. I tested the performance and it's basically identical.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (d4ee7a7) to head (dc9766f).
Report is 2 commits behind head on main.

❗ Current head dc9766f differs from pull request most recent head 47fbc20. Consider uploading reports for the commit 47fbc20 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14743   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files        1322     1322           
  Lines      171364   171327   -37     
  Branches     2461     2454    -7     
=======================================
- Hits       138910   138883   -27     
+ Misses      31983    31976    -7     
+ Partials      471      468    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review February 28, 2024 14:00
@stinodego stinodego merged commit 0be924d into main Feb 28, 2024
17 checks passed
@stinodego stinodego deleted the more-utils branch February 28, 2024 14:24
@c-peters c-peters added the accepted Ready for implementation label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants