test(python): Add test coverage for _cpu_check module
#14768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
stinodego
commented
Feb 29, 2024
Comment on lines
-192
to
-193
| if _POLARS_ARCH != "x86-64": | ||
| return {} |
There was a problem hiding this comment.
It was not possible to end up in this code path as non-x86-64 architectures have no features enabled which causes an early return. So I removed this check.
stinodego
commented
Feb 29, 2024
Comment on lines
-125
to
-127
| if _POLARS_ARCH != "x86-64": | ||
| msg = "CPUID is only available for x86" | ||
| raise SystemError(msg) |
stinodego
changed the title
_cpu_check module._cpu_check module.
stinodego
changed the title
_cpu_check module._cpu_check module
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie and
MarcoGorelli
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14768 +/- ##
==========================================
+ Coverage 80.91% 80.95% +0.04%
==========================================
Files 1324 1324
Lines 171907 171902 -5
Branches 2454 2452 -2
==========================================
+ Hits 139090 139166 +76
+ Misses 32349 32266 -83
- Partials 468 470 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.