Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Seperate asof from join strategy, change parameter from strategy to how in user guide #14793

Merged
merged 1 commit into from
Mar 1, 2024
Merged

docs: Seperate asof from join strategy, change parameter from strategy to how in user guide #14793

merged 1 commit into from
Mar 1, 2024

Conversation

Sol-Hee
Copy link
Contributor

@Sol-Hee Sol-Hee commented Mar 1, 2024

close #14675

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels Mar 1, 2024
stinodego
stinodego approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

We now also have the outer_coalesce strategy. Fancy adding that as well?

@stinodego stinodego merged commit c6dd3d9 into pola-rs:main Mar 1, 2024
5 checks passed
@Sol-Hee
Copy link
Contributor Author

Sol-Hee commented Mar 1, 2024

Great, thanks!

We now also have the outer_coalesce strategy. Fancy adding that as well?

Sure. I'm glad to be able to contribute.
Would it be appropriate to create a new issue to work on the suggestion you've provided?

@stinodego
Copy link
Member

Yes, that would be great!

@Sol-Hee Sol-Hee mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update join strategy in the user guide
2 participants
@Sol-Hee @stinodego