Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix Makefile build commands #14806

Merged
merged 2 commits into from
Mar 1, 2024
Merged

chore: Fix Makefile build commands #14806

merged 2 commits into from
Mar 1, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Mar 1, 2024 •
edited
Loading

Two things:

  • The maturin installation from the current venv was not used.
  • The RUSTFLAGS for the native commands were not picked up correctly.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Mar 1, 2024
@stinodego stinodego marked this pull request as ready for review March 1, 2024 10:33
@stinodego stinodego merged commit 0433de2 into main Mar 1, 2024
3 checks passed
@stinodego stinodego deleted the makefile-maturin-fix branch March 1, 2024 10:34
@c-peters c-peters added the accepted Ready for implementation label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees

@stinodego stinodego

Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stinodego @c-peters