Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure binview types are rle-encoded in parquet write #14818

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Conversation

ritchie46
Copy link
Member

closes #14814

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Mar 2, 2024
@ritchie46 ritchie46 changed the title feat: ensure binview types are rle-encoded in parquet writ feat: Ensure binview types are rle-encoded in parquet write Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 44.06780% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 80.94%. Comparing base (a34e2b0) to head (f87f8b5).
Report is 1 commits behind head on main.

Files Patch % Lines
...rates/polars-parquet/src/arrow/write/dictionary.rs 23.52% 13 Missing ⚠️
crates/polars-arrow/src/array/binview/mutable.rs 33.33% 8 Missing ⚠️
crates/polars-arrow/src/compute/cast/binview_to.rs 50.00% 7 Missing ⚠️
crates/polars-arrow/src/array/indexable.rs 66.66% 3 Missing ⚠️
crates/polars-arrow/src/compute/cast/mod.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14818      +/-   ##
==========================================
- Coverage   80.94%   80.94%   -0.01%     
==========================================
  Files        1325     1325              
  Lines      171952   172002      +50     
  Branches     2452     2452              
==========================================
+ Hits       139188   139225      +37     
- Misses      32292    32307      +15     
+ Partials      472      470       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 9510c22 into main Mar 2, 2024
23 checks passed
@ritchie46 ritchie46 deleted the parquet branch March 2, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

saving parquet with utf8view doesn't use RLE_ENCODING
1 participant