Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Add drop_first parameter to Series.to_dummies #14846

Merged

Conversation

mcrumiller
Copy link
Contributor

Resolves #14843.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Mar 4, 2024
@mcrumiller mcrumiller marked this pull request as ready for review March 4, 2024 22:00
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (baacf3d) to head (6ec7ca5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14846   +/-   ##
=======================================
  Coverage   80.94%   80.95%           
=======================================
  Files        1327     1327           
  Lines      172081   172081           
  Branches     2453     2453           
=======================================
+ Hits       139290   139300   +10     
+ Misses      32320    32311    -9     
+ Partials      471      470    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted 👌
(Relabelling it as an enhancement :)

@alexander-beedie alexander-beedie merged commit 9cc04a2 into pola-rs:main Mar 8, 2024
12 checks passed
@alexander-beedie alexander-beedie changed the title fix(python): Add drop_first parameter to Series.to_dummies feat(python): Add drop_first parameter to Series.to_dummies Mar 8, 2024
@github-actions github-actions bot added the enhancement New feature or an improvement of an existing feature label Mar 8, 2024
@alexander-beedie alexander-beedie removed the fix Bug fix label Mar 8, 2024
@mcrumiller mcrumiller deleted the dummies-series-drop-first branch March 11, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop_first parameter missing from Series.to_dummies
2 participants