chore: Optional deps should include fastexcel
#14907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters and
MarcoGorelli
as code owners
github-actions
bot
added
internal
…versions" output in docstring)
alexander-beedie
force-pushed
the
show-versions-deps
branch
from
bf83068
to
03ab5b9
Compare
alexander-beedie
added
chore
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14907 +/- ##
=======================================
Coverage 81.01% 81.01%
=======================================
Files 1331 1331
Lines 172786 172786
Branches 2456 2456
=======================================
+ Hits 139975 139988 +13
+ Misses 32343 32329 -14
- Partials 468 469 +1 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Mar 8, 2024
alexander-beedie
changed the title
fastexcel fastexcel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor housekeeping;
fastexcelwas listed in "show_versions" but wasn't registered in the optional deps for install when doingpip install "polars[all]". Refreshed the docstring output from "show_versions" while I was at it.