refactor: Deduplicate POLARS_FORCE_ASYNC env var parsing
#14909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickvangelderen
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
ritchie46
approved these changes
Mar 8, 2024
ritchie46
changed the title
POLARS_FORCE_ASYNC env var parsing
github-actions
bot
added
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about the name.
Perhaps we should parse and provide all of polars' configuration coming from env vars in one struct and cache it in a once cell. I don't think it would do much from a performance point of view. I also am not sure that would help organisationally because you're just putting things that look the same together rather than organizing by functionality. So... just doing the simplest thing now.