fix(python): read_database now properly handles empty result sets from arrow-odbc
#14916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters and
MarcoGorelli
as code owners
…rom `arrow-odbc`
alexander-beedie
force-pushed
the
empty-arrow-odbc-result
branch
from
89b3597
to
000dc33
Compare
ritchie46
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14906.
If nothing is yielded from
read_arrow_batches_from_odbc(eg: no matching rows for the given query), we now construct an emptyRecordBatchwith the correct schema and yield that, allowing for successful frame init (vs the currentValueError).Reproduced the issue (and validated the fix) against a local SQL Server instance running in a Docker container, connecting via ODBC.