fix: boolean filter gave overly large buffers to Bitmap::from_u8_vec #14924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14914.
This only patches the what triggers this problem however, the real problem is that
MutableBitmap
has the following invariant:// invariant: length.saturating_add(7) / 8 == buffer.len();
But it does nothing to ensure that invariant is true during initialization (and I haven't yet checked if it maintains it).From a cursory glance it does seem to maintain the invariant, and now I also made sure it satisfies the invariant during initialization.