chore(rust): fix chrono deprecation warnings #14928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlp
requested review from
ritchie46,
stinodego,
c-peters and
MarcoGorelli
as code owners
github-actions
bot
added
internal
orlp
changed the title
MarcoGorelli
approved these changes
Mar 8, 2024
Comment on lines
-163
to
+161
| if v >= 0 { | ||
| NaiveDateTime::from_timestamp_opt( | ||
| // extract seconds from milliseconds | ||
| v / MILLISECONDS, | ||
| // discard extracted seconds and convert milliseconds to nanoseconds | ||
| (v % MILLISECONDS * MICROSECONDS) as u32, | ||
| ) | ||
| } else { | ||
| let secs_rem = (v / MILLISECONDS, v % MILLISECONDS); | ||
| if secs_rem.1 == 0 { | ||
| // whole/integer seconds; no adjustment required | ||
| NaiveDateTime::from_timestamp_opt(secs_rem.0, 0) | ||
| } else { | ||
| // negative values with fractional seconds require 'div_floor' rounding behaviour. | ||
| // (which isn't yet stabilised: https://github.com/rust-lang/rust/issues/88581) | ||
| NaiveDateTime::from_timestamp_opt( | ||
| secs_rem.0 - 1, | ||
| (NANOSECONDS + (v % MILLISECONDS * MICROSECONDS)) as u32, | ||
| ) | ||
| } | ||
| } | ||
| let delta = TimeDelta::try_milliseconds(v)?; | ||
| NaiveDateTime::UNIX_EPOCH.checked_add_signed(delta) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14928 +/- ##
==========================================
+ Coverage 81.01% 81.03% +0.01%
==========================================
Files 1332 1332
Lines 172870 172852 -18
Branches 2458 2458
==========================================
+ Hits 140054 140066 +12
+ Misses 32348 32317 -31
- Partials 468 469 +1 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MarcoGorelli Could you check this out to make sure I didn't mess stuff up?