Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: hoist errors out of iterators in parquet #14945

Merged
merged 5 commits into from
Mar 9, 2024
Merged

perf: hoist errors out of iterators in parquet #14945

merged 5 commits into from
Mar 9, 2024

Conversation

ritchie46
Copy link
Member

A lot of them to go.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Mar 9, 2024
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 40.76923% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 81.01%. Comparing base (02040aa) to head (c8add0f).

❗ Current head c8add0f differs from pull request most recent head ae0dc2c. Consider uploading reports for the commit ae0dc2c to get more accurate results

Files Patch % Lines
...rquet/src/arrow/read/deserialize/dictionary/mod.rs 45.16% 17 Missing ⚠️
.../arrow/read/deserialize/fixed_size_binary/basic.rs 0.00% 14 Missing ⚠️
...parquet/src/arrow/read/deserialize/binary/basic.rs 0.00% 11 Missing ⚠️
...arquet/src/arrow/read/deserialize/binview/basic.rs 30.00% 7 Missing ⚠️
crates/polars-utils/src/iter/fallible.rs 0.00% 5 Missing ⚠️
...arquet/src/arrow/read/deserialize/binary/nested.rs 0.00% 4 Missing ⚠️
...rquet/src/arrow/read/deserialize/binview/nested.rs 0.00% 4 Missing ⚠️
...arrow/read/deserialize/fixed_size_binary/nested.rs 0.00% 4 Missing ⚠️
...lars-parquet/src/parquet/deserialize/hybrid_rle.rs 73.33% 4 Missing ⚠️
...ars-parquet/src/parquet/encoding/hybrid_rle/mod.rs 62.50% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14945      +/-   ##
==========================================
- Coverage   81.02%   81.01%   -0.01%     
==========================================
  Files        1332     1333       +1     
  Lines      172969   172971       +2     
  Branches     2458     2458              
==========================================
- Hits       140143   140129      -14     
- Misses      32359    32375      +16     
  Partials      467      467              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 8599b81 into main Mar 9, 2024
18 checks passed
@ritchie46 ritchie46 deleted the parquet branch March 9, 2024 17:16
@c-peters c-peters added the accepted Ready for implementation label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants