fix: raise proper error instead of panicking when result of truncation is non-existent datetime #14958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n is non-existent datetime
github-actions
bot
added
fix
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie and
orlp
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14958 +/- ##
==========================================
- Coverage 81.02% 80.99% -0.03%
==========================================
Files 1332 1333 +1
Lines 172969 172983 +14
Branches 2458 2458
==========================================
- Hits 140143 140108 -35
- Misses 32359 32408 +49
Partials 467 467 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14957