-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): Implement IpcReaderAsync #14984
feat(rust): Implement IpcReaderAsync #14984
Conversation
mickvangelderen
commented
Mar 11, 2024
•
edited
Loading
edited
- implement basics
- support passing options when reading data
- integrate in default engine
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14984 +/- ##
==========================================
- Coverage 80.99% 80.95% -0.05%
==========================================
Files 1333 1338 +5
Lines 173175 173612 +437
Branches 2458 2460 +2
==========================================
+ Hits 140260 140544 +284
- Misses 32448 32599 +151
- Partials 467 469 +2 ☔ View full report in Codecov by Sentry. |
90f4831
to
3ecb4e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is now in a state where the core seems to work. At the same time the tests are inadequate and this PR also introduces a lot of duplication. Together, this makes it hard to be confident about this change working well for more than the most basic cases.
0d2de57
to
d05ae08
Compare
d05ae08
to
caa7e5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I've left some comments. I think it looks good. We can clean it up and have a second pass. 👍
Great! |