refactor(rust): Apply clippy:assigning_clones lint

crates/polars-core/src/chunked_array/logical/mod.rs

@@ -44,7 +44,7 @@ pub struct Logical<Logical: PolarsDataType, Physical: PolarsDataType>(
 impl<K: PolarsDataType, T: PolarsDataType> Clone for Logical<K, T> {
     fn clone(&self) -> Self {
         let mut new = Logical::<K, _>::new_logical(self.0.clone());
-        new.2 = self.2.clone();
+        new.2.clone_from(&self.2);
         new
     }
 }

crates/polars-core/src/chunked_array/ops/append.rs

@@ -4,7 +4,7 @@ use crate::series::IsSorted;
 pub(crate) fn new_chunks(chunks: &mut Vec<ArrayRef>, other: &[ArrayRef], len: usize) {
     // Replace an empty array.
     if chunks.len() == 1 && len == 0 {
-        *chunks = other.to_owned();
+        other.clone_into(chunks);
     } else {
         for chunk in other {
             if chunk.len() > 0 {

crates/polars-core/src/frame/mod.rs

@@ -933,7 +933,7 @@ impl DataFrame {
                 "unable to append to a DataFrame of width {} with a DataFrame of width {}",
                 self.width(), other.width(),
             );
-            self.columns = other.columns.clone();
+            self.columns.clone_from(&other.columns);
             return Ok(self);
         }
 

crates/polars-lazy/src/frame/mod.rs

@@ -1942,7 +1942,7 @@ impl JoinBuilder {
     /// The passed expressions must be valid in both `LazyFrame`s in the join.
     pub fn on<E: AsRef<[Expr]>>(mut self, on: E) -> Self {
         let on = on.as_ref().to_vec();
-        self.left_on = on.clone();
+        self.left_on.clone_from(&on);
         self.right_on = on;
         self
     }

crates/polars-pipe/src/executors/sinks/group_by/aggregates/first.rs

@@ -55,7 +55,7 @@ impl AggregateFn for FirstAgg {
     fn combine(&mut self, other: &dyn Any) {
         let other = unsafe { other.downcast_ref::<Self>().unwrap_unchecked_release() };
         if other.first.is_some() && other.chunk_idx < self.chunk_idx {
-            self.first = other.first.clone();
+            self.first.clone_from(&other.first);
             self.chunk_idx = other.chunk_idx;
         };
     }

crates/polars-pipe/src/executors/sinks/group_by/aggregates/last.rs

@@ -52,7 +52,7 @@ impl AggregateFn for LastAgg {
     fn combine(&mut self, other: &dyn Any) {
         let other = unsafe { other.downcast_ref::<Self>().unwrap_unchecked_release() };
         if other.last.is_some() && other.chunk_idx >= self.chunk_idx {
-            self.last = other.last.clone();
+            self.last.clone_from(&other.last);
             self.chunk_idx = other.chunk_idx;
         };
     }