Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't count nulls in streaming count agg #15051

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix: Don't count nulls in streaming count agg #15051

merged 2 commits into from
Mar 14, 2024

Conversation

ritchie46
Copy link
Member

fixes #15049

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (82932c6) to head (7366d65).
Report is 6 commits behind head on main.

❗ Current head 7366d65 differs from pull request most recent head a3447a1. Consider uploading reports for the commit a3447a1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15051   +/-   ##
=======================================
  Coverage   81.01%   81.02%           
=======================================
  Files        1338     1338           
  Lines      173595   173593    -2     
  Branches     2461     2461           
=======================================
+ Hits       140635   140647   +12     
+ Misses      32490    32477   -13     
+ Partials      470      469    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit fd9eba2 into main Mar 14, 2024
23 checks passed
@ritchie46 ritchie46 deleted the nulls branch March 14, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming version of polars.LazyFrame.count produces a wrong result when used in aggregation
1 participant