Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return NaN for all-NaN min/max #15066

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Mar 14, 2024

Fixes #15058.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (f08914b) to head (25ab072).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15066      +/-   ##
==========================================
- Coverage   81.04%   81.04%   -0.01%     
==========================================
  Files        1338     1338              
  Lines      173771   173765       -6     
  Branches     2456     2456              
==========================================
- Hits       140832   140822      -10     
- Misses      32471    32476       +5     
+ Partials      468      467       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 307952c into pola-rs:main Mar 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsorted min/max on all-NaN array returns inf/-inf
2 participants