Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Ensure eprintln! is only called within debug/verbose context #15100

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

mcrumiller
Copy link
Contributor

@mcrumiller mcrumiller commented Mar 16, 2024

Resolves #15099.

Also found one more eprintln that wasn't properly wrapped.

Not worth adding a unit test, but OP's example no longer prints the result to stderr.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Mar 16, 2024
@mcrumiller mcrumiller marked this pull request as ready for review March 16, 2024 22:41
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.06%. Comparing base (be92470) to head (311bd66).

Files Patch % Lines
...rc/physical_plan/executors/group_by_partitioned.rs 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15100      +/-   ##
==========================================
- Coverage   81.07%   81.06%   -0.02%     
==========================================
  Files        1342     1342              
  Lines      173942   173948       +6     
  Branches     2459     2459              
==========================================
- Hits       141021   141008      -13     
- Misses      32455    32474      +19     
  Partials      466      466              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Thank you @mcrumiller!

@ritchie46 ritchie46 merged commit 32b7192 into pola-rs:main Mar 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using group_by in certain case prints to stderr when it shouldn't
2 participants