Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support BinaryView in row decoder to prevent a panic in streaming group by #15117

Merged
merged 3 commits into from
Mar 18, 2024
Merged

fix: Support BinaryView in row decoder to prevent a panic in streaming group by #15117

merged 3 commits into from
Mar 18, 2024

Conversation

mkysylov
Copy link
Contributor

Fixes #15116

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 17, 2024
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.08%. Comparing base (f8ade71) to head (60b76a7).
Report is 5 commits behind head on main.

❗ Current head 60b76a7 differs from pull request most recent head 5ddbed0. Consider uploading reports for the commit 5ddbed0 to get more accurate results

Files Patch % Lines
crates/polars-row/src/decode.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15117   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files        1342     1342           
  Lines      174112   174112           
  Branches     2459     2459           
=======================================
+ Hits       141178   141180    +2     
+ Misses      32467    32465    -2     
  Partials      467      467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

ritchie46 commented Mar 18, 2024

Thanks! Can you add a test? Your issue example could be added as test on the python side.

@ritchie46 ritchie46 merged commit c0fada8 into pola-rs:main Mar 18, 2024
22 of 23 checks passed
@ritchie46
Copy link
Member

Thank you @MKisilyov. I added a test quickly so we can include this one in our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming group by causes a panic if key has Binary type
2 participants