fix: Output correct dtype for mean_horizontal on a single column
#15118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15118 +/- ##
==========================================
+ Coverage 81.14% 81.16% +0.02%
==========================================
Files 1363 1368 +5
Lines 175282 175414 +132
Branches 2527 2527
==========================================
+ Hits 142236 142381 +145
+ Misses 32568 32555 -13
Partials 478 478 ☔ View full report in Codecov by Sentry. |
mcrumiller
changed the title
f64 when mean_horizontal provided with single boolean columnmean_horizontal on a single column
mcrumiller
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
ritchie46
approved these changes
Mar 18, 2024
|
Can you rebase? |
ritchie46
requested changes
Mar 18, 2024
Done. I'll rebase when I'm up. 3am here, cat is throwing up :(. |
Ai, sleep well! 🙈 To you and your cat! |
mcrumiller
force-pushed
the
mean-horz-bool
branch
from
7e0627f
to
82cb292
Compare
|
@ritchie46 rebased, but let's wait for CI to finish since there were a lot of conflicts with the other PR to navigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15115. Sibling to #15114.