Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr(python): Rename from_repr parameter from tbl to data #15156

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Mar 19, 2024

Just something super minor I ran into while working on the code in this module. There are probably very few people using this parameter name directly as a keyword argument.

tbl isn't really in line with the naming conventions we usually use (write out the words in full). Also, when it's a Series, 'table' doesn't make much sense.

Better to just use data as a parameter name, matching all other from_x functions. It's just data in a specific format.

I also moved it some lines down the module because it's not as important as other functions like from_pandas etc.

@github-actions github-actions bot added deprecation Add a deprecation warning to outdated functionality python Related to Python Polars labels Mar 19, 2024
@stinodego stinodego marked this pull request as ready for review March 19, 2024 10:33
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 82.27848% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 81.18%. Comparing base (83c3fb0) to head (5d756a3).

Files Patch % Lines
py-polars/polars/convert.py 82.27% 6 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15156      +/-   ##
==========================================
- Coverage   81.18%   81.18%   -0.01%     
==========================================
  Files        1347     1347              
  Lines      175431   175433       +2     
  Branches     2506     2506              
==========================================
- Hits       142426   142423       -3     
- Misses      32524    32530       +6     
+ Partials      481      480       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 6be154c into main Mar 19, 2024
16 checks passed
@stinodego stinodego deleted the depr-from-repr-param branch March 19, 2024 11:12
@c-peters c-peters added the accepted Ready for implementation label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation deprecation Add a deprecation warning to outdated functionality python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants