Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add AlignedBitmapSlice #15171

Merged
merged 8 commits into from
Mar 22, 2024
Merged

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Mar 19, 2024

This should simplify writing efficient bitmap loops (assuming there's only a single bitmap, so only a single offset to worry about), I've already applied it in a couple places and recouped the LOC cost of adding it.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Mar 19, 2024
@orlp orlp self-assigned this Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 92.25806% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 81.25%. Comparing base (45dff18) to head (25c04eb).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/polars-compute/src/filter/boolean.rs 0.00% 8 Missing ⚠️
crates/polars-arrow/src/bitmap/aligned.rs 96.55% 3 Missing ⚠️
crates/polars-arrow/src/bitmap/utils/fmt.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15171      +/-   ##
==========================================
- Coverage   81.25%   81.25%   -0.01%     
==========================================
  Files        1355     1356       +1     
  Lines      175648   175636      -12     
  Branches     2518     2518              
==========================================
- Hits       142730   142718      -12     
  Misses      32436    32436              
  Partials      482      482              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d214f55 into pola-rs:main Mar 22, 2024
18 checks passed
@c-peters c-peters added the accepted Ready for implementation label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants