Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): Warn if map_elements is called without return_dtype specified #15188

Merged
merged 5 commits into from
Mar 21, 2024
Merged

feat(python): Warn if map_elements is called without return_dtype specified #15188

merged 5 commits into from
Mar 21, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

closes #9099

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Mar 20, 2024
@MarcoGorelli MarcoGorelli changed the title feat: warn if map_elements is called without return_dtype specified feat(python): warn if map_elements is called without return_dtype specified Mar 20, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.22%. Comparing base (28414f5) to head (2748b8f).

❗ Current head 2748b8f differs from pull request most recent head 5aaaebc. Consider uploading reports for the commit 5aaaebc to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15188      +/-   ##
==========================================
- Coverage   81.25%   81.22%   -0.03%     
==========================================
  Files        1354     1348       -6     
  Lines      175633   175338     -295     
  Branches     2518     2508      -10     
==========================================
- Hits       142708   142416     -292     
+ Misses      32444    32442       -2     
+ Partials      481      480       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review March 20, 2024 18:01
@stinodego stinodego changed the title feat(python): warn if map_elements is called without return_dtype specified feat(python): Warn if map_elements is called without return_dtype specified Mar 21, 2024
stinodego
stinodego requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting in the legwork on this one 👍 Just one comment about the warning type.

py-polars/src/series/mod.rs Outdated Show resolved Hide resolved
@MarcoGorelli @stinodego
Update py-polars/src/series/mod.rs
2d6d015 
Co-authored-by: Stijn de Gooijer <stijndegooijer@gmail.com>
@MarcoGorelli MarcoGorelli marked this pull request as draft March 21, 2024 11:59
@MarcoGorelli MarcoGorelli marked this pull request as ready for review March 21, 2024 19:06
@MarcoGorelli MarcoGorelli requested a review from orlp as a code owner March 21, 2024 19:06
stinodego
stinodego approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Marco!

@stinodego stinodego merged commit 45dff18 into pola-rs:main Mar 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn if return_dtype is not set in map_elements
2 participants
@MarcoGorelli @stinodego